Skip to content

Updated grpc to 1.74.0. #593 #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AltamashShaikh merged 4 commits into from
Sep 29, 2025
Merged

Updated grpc to 1.74.0. #593 #594

AltamashShaikh merged 4 commits into from
Sep 29, 2025

Conversation

@AltamashShaikh
Copy link
Contributor

@AltamashShaikh AltamashShaikh commented Sep 26, 2025

Description

Updated grpc to 1.74.0.

Issue No

#593

Steps to Replicate the Issue

  1. Run the import command to check if imports correctly
./console googleanalyticsimporter:import-ga4-reports --property="properties/{propertyID}" --dates=2022-06-01,2022-06-02

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [NA] New test case added/updated?
  • [NA] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✔] Version bumped?

@AltamashShaikh AltamashShaikh mentioned this pull request Sep 26, 2025
Closed
@AltamashShaikh AltamashShaikh requested a review from a team September 26, 2025 12:16
snake14
snake14 previously approved these changes Sep 28, 2025
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was able to run a test import without any issues 👍

I just had one question about the changelog.

@AltamashShaikh AltamashShaikh merged commit 3b84d5f into 5.x-dev Sep 29, 2025
7 checks passed
@AltamashShaikh AltamashShaikh deleted the 593-update-grpc branch September 29, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snake14 snake14 snake14 approved these changes

@james-hill-matomo james-hill-matomo Awaiting requested review from james-hill-matomo

Assignees

No one assigned

Labels

Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AltamashShaikh @snake14 @james-hill-matomo